Add storage opt in hub. Can now configure localStorage or sessionStorage #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I made this because we needed support for sessionStorage option.
Changes :
Hub()constructor now accepts a singleoptsargumentsopts.permissionsbehaves like previouslypermissionsopts.storageis added. Can be one ofwindow.localStorageandwindow.sessionStorage(or any object with the same API, I guess). It defaults towindow.localStorageCompat checks with
window.localStorageare now made toopts.storageTODO : Some tests should be added to ensure